Fix build failure on non-arm 32bit architectures #264
Conversation
|
@helmutg thanks for looking into this. Does this fix need to go into the For context: the |
|
The Debian package will include the original commit as it would fail to build otherwise. See https://salsa.debian.org/python-team/packages/austin. I've rebased it on devel. |
|
All the Linux tests are failing. From the logs I can see which makes me think that this might be related to the changes around the /proc/maps parsing 🤔 |
An incompatible format triggers -Werror=format-security. %zu is widely available and is the correct type for size_t. The correct format string to be used for uintptr_t is defined in inttypes.h. When casting from a pointer to an integer, we trip up -Werror=pointer-to-int-cast unless the target integer type has exactly the same size as a pointer.
|
Thanks for pointing at the root cause. I introduced the problem in my rebase onto devel where I messed up converted |
|
I am unsure whether this is any better now. The error from the aarch64 build doesn't quite look like my fault. The armv7 build looks like it is trying to combine a recent I cannot make sense of the data validation failures. Meanwhile, the patched Debian build fails to pass smoke tests on i386 (segmentation fault) and s390x (non-zero exit). Chances are we are not done yet. |
Yep these are not related to this PR. I have tried to fix these but with no success :(.
These are "broken" at the moment because of a recent change I made that increases the default sampling interval for
It would help if we could get some core dumps/backtraces from i386, and logs from s390x to investigate these further 🙏 . In the meantime, I think this PR is probably good to go, as it sounds like the build is fine now? |
An incompatible format triggers -Werror=format-security. %zu is widely available and is the correct type for size_t. The correct format string to be used for uintptr_t is defined in inttypes.h.
When casting from a pointer to an integer, we trip up -Werror=pointer-to-int-cast unless the target integer type has exactly the same size as a pointer.